Preserve field order when updating kustomization.yaml file #666
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #666 +/- ##
==========================================
- Coverage 67.98% 67.84% -0.15%
==========================================
Files 31 31
Lines 3124 3135 +11
==========================================
+ Hits 2124 2127 +3
- Misses 856 860 +4
- Partials 144 148 +4 ☔ View full report in Codecov by Sentry. |
|
The |
jtdoepke
force-pushed
the
kustomize-keep-order
branch
from
be96678
to
3b8a879
Compare
jtdoepke
force-pushed
the
kustomize-keep-order
branch
from
3b8a879
to
a98c209
Compare
jtdoepke
requested review from
jannfis,
chengfang and
pasha-codefresh
as code owners
chengfang
reviewed
Jul 17, 2024
|
@jtdoepke can you also fix the DCO failure with sign-off? |
This commit causes argocd-image-updater to preserve the order of fields in the kustomization.yaml file when updating the image(s). Doing so will minimize git diffs in the case that other tools also edit the kustomization.yaml file. Fixes argoproj-labs#502 Signed-off-by: Jaye Doepke <jdoepke@mintel.com>
jtdoepke
force-pushed
the
kustomize-keep-order
branch
from
a98c209
to
05aa475
Compare
chengfang
approved these changes
Jul 17, 2024
|
@jtdoepke thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit causes argocd-image-updater to preserve the order of fields in the
kustomization.yamlfile when updating the image(s). Doing so will minimize git diffs in the case that other tools also edit thekustomization.yamlfile.Fixes #502